[AIPS] Patches to AIPS 31DEC12 [NRAO]

This page most recently updated on $Date: 2013/10/24 15:29:59 $ (UT)

You will find patches to known bugs in 31DEC12 here.

With previous releases, we did not change the frozen release tar ball; user sites were required to download the text files and do any compilations themselves. But, beginning with 31DEC04, we provide binary releases for which user sites are not required to have compilers. Therefore, we have reversed our policy. These patches have been applied to the official code of 31DEC12 and may be downloaded using a 31DEC12 "Midnight Job". Any tarball taken after the change date listed below will already have the patches applied. Of course, you may still download and compile the files as before.

The following is a list of pointers to the different patches in this document.

  1. Bandpass calibration was not applied to enough channels to support frequency smoothing afterwards. 2013-01-16
  2. Tick increments were computed with an erroneous round-off parameter leading some tick marks to be plotted at offset values. 2013-01-29
  3. POSSM had a variety of irritating bugs. 2013-02-05
  4. FITLD turned off DIGICOR corrections when the array name was not VLBA. 2013-02-05
  5. FITLD, after correction 4, failed if it could not make a CQ table. 2013-02-18
  6. CL2HF aborted because of an internal name conflict 2013-02-19
  7. PRTAB had a format issue with large F formats (NDIG <= 0).2013-03-01
  8. COMB did not do POLC correctly when using constant noise values 2013-04-04
  9. AFARS had a header bug causing it to try to write too much 2013-04-05
  10. FITLD could get the EQUINOX wrong in the SU table with FITS-IDI input 2013-04-11
  11. COMB messed up scaling when combining two images with one of them not JY/BEAM 2013-05-03
  12. FITLD had a bad warning message, causing aborts on some machines. 2013-05-21
  13. BPASS rounded times outward for each scan by too much 2013-06-17
  14. IMAGR computed the actual average frequency wrongly 2013-07-03
  15. IMFIT and JMFIT could return negative error bars when the object was negative 2013-07-07
  16. TRANS messed up when reversing the order of an axis it was also swapping 2013-07-17
  17. PRTAB had formatting issues with large tables with many blanked values. 2013-07-25
  18. SU table access was incorrect in some routines including widely used ones 2013-07-29
  19. SPFLG had a gridding counter which could overflow with modern data sets 2013-08-16
  20. PRTAB had formatting issues with required E formats in F-format modes 2013-08-23
  21. SETJY and CVEL were affected by a bad variable in setting the Doppler velocity and the former omitted the system velocity when setting source velocities. 2013-10-21
  22. ISPEC on an image with an FQID axis could fail 2013-10-24
  23. 2013-??-??

The remainder of this document is comprised of the patch descriptions pointed to by the above references.

Task:
Summary: The subroutine that applies the bandpass correction to the data can be called either after or before the frequency smoothing (depending on what smoothing was done to prepare the bandpass correction). It limited the correction to BCHAN to ECHAN without correcting the needed channels less than BCHAN and greater than ECHAN which will be used in the smoothing. Corrected the loop limits.
Files:
/31DEC12/APL/SUB/NOTST/DATBND.FOR
/31DEC12/APL/SUB/NOTST/DOBAND.LST
Fix:
  1. Fetch the files listed above and place the first in the corresponding area ($APLNOT) on your system. Place the second in the disk directory in which you are working.
  2. COMRPL $APLNOT/DATBND
  3. source DOBAND.LST
Documentor:
Eric W Greisen
Date:
2013-01-16
Task:
Summary: The subroutine that computes tick increments also supplies a "round-off" value. When it was revised in November 2012 to allow finer tick intervals, certain subscript references were not updated leading to bad round off values. This could lead the tick labels to be offset from their correct values. For example, 2 minutes of time was often added to times.
Files:
/31DEC12/APL/SUB/ticinc.FOR
/31DEC12/APL/SUB/TICINC.LST
Fix:
  1. Fetch the files listed above and place the first in the corresponding area ($APLSUB) on your system. Place the second in the disk directory in which you are working.
  2. COMRPL $APLSUB/TICINC
  3. source TICINC.LST
Documentor:
Eric W Greisen
Date:
2013-01-29
Task:
POSSM
Summary: Corrected a number of irritating bugs. When plotting BD tables it would sometimes abort since the wrong close subroutine was called. The task did not understand "formal i" Stokes and so looped badly. It did not initialize values correctly for the upper plot, causing the labeling/scaling not to appear properly. Finally, when plotting a single baseline it would still read and calibrate all data before discarding the unwanted samples. Changed it to ask the low level routines only for the desired baseline.
Files:
/31DEC12/Y/PGM/NOTST/POSSM.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($YPGNOT) on your system.
  2. COMLNK $YPGNOT/POSSM
Documentor:
Eric W Greisen
Date:
2013-02-05
Task:
FITLD
Summary: tested the array name from the antenna file and, if it was not VLBA turned off the creation of a CQ table and the application of digital corrections. Changed it to use the user's value of DIGICOR for better or for worse and changed the help file to say so. Note that DiFX IDI files probably assert array name VLBA even when it is not.
Files:
/31DEC12/APL/PGM/NOTST/FITLD.FOR
/31DEC12/HELP/FITLD.HLP
Fix:
  1. Fetch the files listed above and place them in the corresponding areas ($APGNOT and $HLPFIL) on your system.
  2. COMLNK $APGNOT/FITLD
Documentor:
Eric W Greisen
Date:
2013-02-05
Task:
FITLD
Summary: was changed in correction 4 above to attempt to make and fill a CQ table as well as doing the digital corrections. Some IDI data lack the information needed to do this, so the task was changed to report this failure while not regarding it as fatal.
Files:
/31DEC12/APL/PGM/NOTST/FITLD.FOR
/31DEC12/HELP/FITLD.HLP
Fix:
  1. Fetch the files listed above and place them in the corresponding areas ($APGNOT and $HLPFIL) on your system.
  2. COMLNK $APGNOT/FITLD
Documentor:
Eric W Greisen
Date:
2013-02-18
Task:
CL2HF
Summary: had a common named ANINI which conflicted with a subroutine created September 20, 2009 which the task has to call. Changed the name of the COMMON.
Files:
/31DEC12/APL/PGM/OOP/CL2HF.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APGOOP) on your system.
  2. COMLNK $APGOOP/CL2HF
Documentor:
Eric W Greisen
Date:
2013-02-19
Task:
PRTAB
Summary: had an error in which it could compute an illegal format to use on very large floating numbers in the F format (NDIG <= 0) option.
Files:
/31DEC12/APL/PGM/PRTAB.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
  2. COMLNK $APLPGM/PRTAB
Documentor:
Eric W Greisen
Date:
2013-03-01
Task:
COMB
Summary: did not do OPCODE = 'POLC' correctly with constant noise values (rather than noise images). It applied a beam area correction to the constant values making them nearly zero and hence making the polarization bias correction negligible.
Files:
/31DEC12/APL/PGM/COMB.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
  2. COMLNK $APLPGM/COMB
Documentor:
Eric W Greisen
Date:
2013-04-04
Task:
AFARS
Summary: had a bug in setting up the output header which caused it to try to write multiple planes when in fact it should write only one. The task then died and deleted the output files.
Files:
/31DEC12/APL/PGM/NOTST/AFARS.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APGNOT) on your system.
  2. COMLNK $APGNOT/AFARS
Documentor:
Eric W Greisen
Date:
2013-04-05
Task:
FITLD
Summary: was affected by a buffer declaration that was too small. On some compilers, the overflow affected parameters that sometimes mattered (and sometime did not). The EQUINOX in the SU table would end up set to -1 when this occurred. A truncated error message from SOTAB would also appear. This only happened with FITS-IDI format VLB data.
Files:
/31DEC12/INC/DSOV.INC
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($INC) on your system.
  2. COMRPL $APLNOT/SO{IO,INI,TAB}.FOR
  3. COMLNK $APGNOT/FITLD.FOR
Documentor:
Eric W Greisen
Date:
2013-04-11
Task:
COMB
Summary: messed up the scaling when one of the images was not in units of JY/BEAM and the other was.
Files:
/31DEC12/APL/PGM/COMB.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
  2. COMLNK $APLPGM/COMB
Documentor:
Eric W Greisen
Date:
2013-05-03
Task:
FITLD
Summary: had a warning message in the IDI section that had more arguments than format items. It caused aborts on some machines.
Files:
/31DEC12/APL/PGM/NOTST/FITLD.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APGNOT) on your system.
  2. COMLNK $APGNOT/FITLD.FOR
Documentor:
Eric W Greisen
Date:
2013-05-21
Task:
BPASS
Summary: rounded out the scan time range by 4.3 seconds. This can overlap with the next scan if that scan started promptly (e.g. the same source). Changed it to 0.43 seconds. This could cause a "scan average" solution to be generated for a very short interval in an overlap region of time. That poor solution would be averaged with good ones without appropriately low weight.
Files:
/31DEC12/Q/PGM/NOTST/BPASS.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($QPGNOT) on your system.
  2. COMLNK $QPGNOT/BPASS
Documentor:
Eric W Greisen
Date:
2013-06-17
Task:
IMAGR
Summary: computed the actual average frequency by a method that worked correctly only if there is only one Stokes and if the frequencies increase or decrease monotonically with channel number.
Files:
/31DEC12/Q/PGM/OOP/IMAGR.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($QPGOOP) on your system.
  2. COMLNK $QPGOOP/IMAGR
Documentor:
Eric W Greisen
Date:
2013-07-03
Task:
IMFIT
Summary: and JMFIT must scale the error bars by the ratio of the image rms and the fit peak. When that peak was negative, the error bars returned by the task in DOPOS and DOWIDTH were negative. This caused the next fit to hold the position and width constant. Corrected both tasks to use absolute values for the errors.
Files:
/31DEC12/APL/PGM/NOTST/IMFIT.FOR
/31DEC12/APL/PGM/NOTST/JMFIT.FOR
Fix:
  1. Fetch the files listed above and place them in the corresponding area ($APGNOT) on your system.
  2. COMLNK $APGNOT/{I,J}MFIT
Documentor:
Eric W Greisen
Date:
2013-07-07
Task:
TRANS
Summary: failed to reverse the order of an axis and tried to write off the end of the output file during the row swap routine, when the axis being swapped required reversal. Thus TRANSCOD='-312' failed.
Files:
/31DEC12/APL/PGM/TRANS.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
  2. COMLNK $APLPGM/TRANS
Documentor:
Eric W Greisen
Date:
2013-07-17
Task:
PRTAB
Summary: used to check only 5000 rows when trying to decide on formats. The new tables from XGAUS, RMFIT, and ZEMAN might not have any valid data in the first 5000 rows, so the limit was changed to 50000. Also adjusted the handling of formats a little and applied an earlier change to allow non-integer intervals in RPARM with integer-valued columns.
Files:
/31DEC12/APL/PGM/PRTAB.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
  2. COMLNK $APLPGM/PRTAB
Documentor:
Eric W Greisen
Date:
2013-07-25
Task:
SU
Summary: tables now have 21 columns. Some places used 20 for the size of the pointer arrays used during table access. They should have used MAXSUC from the standard uv data parameter include. Unfortunately, this includes 2 widely used subroutines.
Files:
/31DEC12/APL/SUB/NOTST/GETSOU.COM
/31DEC12/APL/SUB/NOTST/GETSOU.FOR
/31DEC12/APL/SUB/NOTST/SOUFIL.FOR
/31DEC12/APL/PGM/NOTST/FILLM.FOR
/31DEC12/APL/PGM/NOTST/FIXAL.FOR
/31DEC12/APL/PGM/NOTST/HAFIX.FOR
/31DEC12/APL/PGM/NOTST/TRUEP.FOR
/31DEC12/APL/PGM/NOTST/UVFIX.FOR
/31DEC12/Y/PGM/NOTST/FRMAP.FOR
/31DEC12/Y/PGM/NOTST/POSSM.FOR
Fix:
  1. Fetch the files listed above and place the first in a convenient work area. Place the others in the corresponding areas (2 in $APLNOT, 5 in $APGNOT, 2 in $YPGNOT) on your system.
  2. COMRPL $APLNOT/{GETSOU,SOUFIL}
  3. source GETSOU.COM
Documentor:
Eric W Greisen
Date:
2013-07-29
Task:
SPFLG
Summary: had a gridding counter that was limited to 2 billion (2^31 - 1) before it would overflow. Modern instruments can exceed this so the counter was changed to double precision float.
Files:
/31DEC12/Y/PGM/NOTST/SPFLG.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($YPGNOT) on your system.
  2. COMLNK $YPGNOT/SPFLG
Documentor:
Eric W Greisen
Date:
2013-08-16
Task:
PRTAB
Summary: now prints in F-format mode by default. This may not work for some columns (e.g. delays) which have very small or very large values. When switching to E format for such columns, the second digit of the exponent got omitted from the display.
Files:
/31DEC12/APL/PGM/PRTAB.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
  2. COMLNK $APLPGM/PRTAB
Documentor:
Eric W Greisen
Date:
2013-08-23
Task:
SETJY, CVEL
Summary: had the date wrong with some compilers (32-bit Intel and perhaps Mac) when determining the Doppler velocities. SETJY also forgot to include the "system velocity" in the output velocity in the radio velocity convention. It was included in the optical convention.
Files:
/31DEC12/APL/SUB/NOTST/CVLDOP.FOR
/31DEC12/APL/PGM/NOTST/SETJY.FOR
Fix:
  1. Fetch the files listed above and place them in the corresponding area ($APLNOT and $APGNOT, resp.) on your system.
  2. COMRPL $APLNOT/CVLDOP
  3. COMLNK $APGNOT/SETJY
  4. COMLNK $QPGNOT/{CVEL,BPASS}
Documentor:
Eric W Greisen
Date:
2013-10-21
Task:
ISPEC
Summary: and RSPEC, BLSUM, and, SLICE could fail (depending on compiler) when running on an image with a FQID axis.
Files:
/31DEC12/APL/SUB/FRQGET.FOR
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($APLSUB) on your system.
  2. COMRPL $APLSUB/FRQGET
  3. COMLNK $APGNOT/SLICE
  4. COMLNK $YPGM/{ISPEC,RSPEC,BLSUM}
Documentor:
Eric W Greisen
Date:
2013-10-24
Task:
Summary:
Files:
/31DEC12/
Fix:
  1. Fetch the file listed above and place it in the corresponding area ($???) on your system.
  2. COMLNK $
Documentor:
Eric W Greisen
Date:
2013-??-??
Eric W. Greisen