Patches to 31DEC18

You will find patches to known bugs in 31DEC18 here.

With previous releases, we did not change the frozen release tar ball; user sites were required to download the text files and do any compilations themselves. But, beginning with 31DEC04, we provide binary releases for which user sites are not required to have compilers. Therefore, we have reversed our policy. These patches have been applied to the official code of 31DEC18 and may be downloaded using a 31DEC18 "Midnight Job". Any tarball taken after the change date listed below will already have the patches applied. Of course, you may still download and compile the files as before.

The following is a list of pointers to the different patches in this document.

1. VBCAL did not write the output data set. 2019-01-18
2. TYCOP and other tasks had the old number of columns for the SY table. 2019-02-13
3. Model computation had problems when computing multiple CC models. 2019-03-05
4. Conversion of linear polarization to Stokes had a wrong sign. 2019-03-05
5. TYSMOapplied clipping and flags inconsistently. 2019-03-05
6. FILIT had an infinite loop displaying the image facets and did not handle the roam function properly 2019-03-28
7. KNTR and other tasks truncated one of the "brightness" strings 2019-04-03
8. OOSUB did not do channel dependent division correctly. 2019-04-10
9. SPIXR did not handle sub-images with an FQ axis correctly. 2019-05-03
10. RFLAG did not handle missing data correctly, making too many flags. 2019-06-14
11. KNTR computed the number of planes to plot poorly 2019-06-14
12. BPWAY, RLCOR did not change uvw for BIF greater than one.2019-06-14
13. TAPLT tested for no data backwards and so did not do good plots. 2019-06-21
14. BPASS messed up some of the standard source spectral indices. 2019-07-12
15. CLIP messed up reporting its results for linear and other non-standard polarization data. 2019-07-26
16. UVFLG did not use the correct antenna data when looping over subarrays for shadowing. 2019-08-22
17. BPWAY did not close the table IO when looping over scans 2019-09-30
18. TYSMO could ignore some flags when applying an FG table to the TY/SY data. 2019-11-18
19. 2019-??-??

The remainder of this document is comprised of the patch descriptions pointed to by the above references.

Task:

VBCAL

Summary: failed to write out any of the output data set. The FPARM et al. defaults were also not set.

Files:

/31DEC18/APL/PGM/NOTST/VBCAL.FOR

/31DEC18/HELP/VBCAL.HLP

Fix:

1. Fetch the files listed above and place them in the corresponding areas ($APGNOT AND $HLPFIL) on your system.
2. COMLNK $APGNOT/VBCAL

Documentor:

Eric W Greisen

Date:

2019-01-18

Task:

TYCOP, PRTSY, VLAMP, SY2TY

Summary: had the old number of columns (12) for the SY table. This caused issues over-writing memory, especially in optimised load modules.

Files:

/31DEC18/APL/PGM/NOTST/TYCOP.FOR

/31DEC18/APL/PGM/NOTST/PRTSY.FOR

/31DEC18/APL/PGM/NOTST/VLAMP.FOR

/31DEC18/APL/PGM/NOTST/SY2TY.FOR

Fix:

1. Fetch the files listed above and place them in the corresponding area ($APGNOT) on your system.
2. COMLNK $APGNOT/{TYCOP,PRTSY,VLAMP,SY2TY}

Documentor:

Eric W Greisen

Date:

2019-02-13

Task:

Model

Summary: computation when using multiple models to support multiple facets or multiple frequency spectral index or primary beam had several issues. The zeroing of the input data has to be done before the Q routines and has to only zero those channels and polarizations currently being processed. Issues when different numbers of channels are found in the models were also addressed.

Files:

/31DEC18/Q/SUB/NOTST/ALGMEM.FOR

/31DEC18/Q/SUB/NOTST/VISDFT.FOR

/31DEC18/Q/DEV/PSAP/QXXPTS.FOR

/31DEC18/Q/DEV/PSAP/QGASUB.FOR

/31DEC18/Q/DEV/PSAP/QSPSUB.FOR

/31DEC18/Q/SUB/OOP/PBUTIL.FOR

/31DEC18/APL/SUB/FORCED.FOR

/31DEC18/Q/PGM/OOP/OOSUB.FOR

/31DEC18/Q/SUB/NOTST/ALGMEM.COM

Fix:

1. Fetch the files listed above and place them in the corresponding ares ($QNOT, $QPSAP, $QOOP, $APLSUB, $QPGOOP and your work area, resp.) on your system.
2. COMRPL $QNOT/{ALGMEM,VISDFT}
3. COMRPL $QPSAP/Q{XXPTS,GASUB,SPSUB}
4. COMRPL $QOOP/PBUTIL
5. COMRPL $APLSUB/FORCED
6. source ALGMEM.COM

Documentor:

Eric W Greisen

Date:

2019-03-05

Task:

Conversion

Summary: of linear polarization into true Stokes used the wrong sign of the parallactic angles.

Files:

/31DEC18/APL/SUB/NOTST/DXYGET.FOR

/31DEC18/APL/SUB/NOTST/DXYGET.COM

Fix:

1. Fetch the files listed above and place them in the corresponding areas ($APLNOT and your work area) on your system.
2. COMRPL $APLNOT/DXYGET
3. source DXYGET.COM

Documentor:

Eric W Greisen

Date:

2019-03-05

Task:

TYSMO

Summary: was inconsistent when clipping and flagging. The subroutine that applied the data flags to the SY table had to be updated for the new table format. Clipping was applied to the input to the MWF smoothing but was not applied to the output of the smoothing. Flagging was done on Psys even when no flagging on Psys was requested. A per scan normalization option was added.

Files:

/31DEC18/APL/PGM/NOTST/TYSMO.FOR

/31DEC18/HELP/TYSMO.HLP

Fix:

1. Fetch the files listed above and place them in the corresponding area ($APGNOT, $HLPFIL) on your system.
2. COMLNK $APGNOT/TYSMO

Documentor:

Eric W Greisen

Date:

2019-03-05

Task:

FILIT

Summary: started displaying the first facet, but instead of displaying the menu thereafter, it went on to display the second facet and so on forever. This failure was corrected and the handling of the roam function was also fixed. It did not adjust the lookup tables of all of the planes. FILIT also failed to detect that it was given a UV data set as the first input image.

Files:

/31DEC18/APL/SUB/OOP/TVUTIL.FOR

/31DEC18/APL/PGM/OOP/FILIT.FOR

Fix:

1. Fetch the files listed above and place them in the corresponding areas ($APLOOP and $APGOOP, resp.) on your system.
2. COMRPL $APLOOP/TVUTIL
3. COMLNK $APGOOP/FILIT

Documentor:

Eric W Greisen

Date:

2019-03-28

Task:

KNTR

Summary: and several other tasks truncated one of the "brightness" strings in the output plot. The LEVS strings were also made longer.

Files:

/31DEC18/Y/SUB/COMLAB.FOR

/31DEC18/Y/PGM/GREYS.FOR

/31DEC18/Y/PGM/KNTR.FOR

/31DEC18/Y/PGM/PCNTR.FOR

Fix:

1. Fetch the files listed above and place them in the corresponding areas ($YSUB and $YPGM) on your system.
2. COMrpl $YSUB/COMLAB
3. COMLNK $YPGM/{GREYS,KNTR,PCNTR}
4. COMLNK $YPGM/{CNTR,CCNTR}

Documentor:

Eric W Greisen

Date:

2019-04-03

Task:

OOSUB

Summary: when doing channel-dependent division zeroed the incoming data for channels in the third group and beyond. The actual error was in subroutine UVMDIV and has been present since 2008. A similar error in EVAUV probably never affected the output.

Files:

/31DEC18/QY/PGM/NOTST/EVAUV.FOR

/31DEC18/Q/SUB/NOTST/UVMDIV.FOR

/31DEC18/Q/SUB/NOTST/UVMDIV.COM

Fix:

1. Fetch the files listed above and place them in the corresponding areas ($QYPGNOT, $QNOT, and a work area) on your system.
2. COMRPL $QNOT/UVMDIV
3. source UVMDIV.COM

Documentor:

Eric W Greisen

Date:

2019-04-10

Task:

SPIXR

Summary: when dealing with an image that had been SUBIMed on the FQ axis failed to select frequencies properly. This led to memory being over-written with subsequent issues In favorable cases, it might have worked correctly..

Files:

/31DEC18/APL/PGM/SPIXR.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($APLPGM) on your system.
2. COMLNK $APLPGM/SPIXR

Documentor:

Eric W Greisen

Date:

2019-05-03

Task:

RFLAG

Summary: failed to keep track of what cells in the accumulation array had been sampled when doing an average. Old cells, not sampled this time, then retained value potentially changed to large values if the sum of weights was very small. Too many excess flux flags and even Nans could result.

Files:

/31DEC18/Y/PGM/NOTST/RFLAG.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($YPGNOT) on your system.
2. COMLNK $YPGNOT/RFLAG

Documentor:

Eric W Greisen

Date:

2019-06-14

Task:

KNTR

Summary: computed the number of planes to plot poorly, sometimes plotting an extra, even non-existant, plane.

Files:

/31DEC18/Y/PGM/KNTR.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($YPGM) on your system.
2. COMLNK $YPGM/KNTR

Documentor:

Eric W Greisen

Date:

2019-06-14

Task:

BPWAY

Summary: and RLCOR did not take BIF into account when scaling the uvw's to the output file. This led to wrong image scaling.

Files:

/31DEC18/APL/PGM/NOTST/BPWAY.FOR

/31DEC18/APL/PGM/NOTST/RLCOR.FOR

Fix:

1. Fetch the files listed above and place them in the corresponding area ($APGNOT) on your system.
2. COMLNK $APGNOT/{BPWAY,RLCOR}

Documentor:

Eric W Greisen

Date:

2019-06-14

Task:

TAPLT

Summary: had a test for whether good data had been found. The test was backwards and so no data could ever be plotted.

Files:

/31DEC18/Y/PGM/TAPLT.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($YPGM) on your system.
2. COMLNK $YPGM/TAPLT

Documentor:

Eric W Greisen

Date:

2019-06-21

Task:

BPASS

Summary: used the wrong source list for the standard sources for data after 2014. It got 3C286, 3C48, and 3C147 correct but had bad values for other sources. CPASS needed the same correction.

Files:

/31DEC18/Q/PGM/NOTST/BPASS.FOR

/31DEC18/Q/PGM/NOTST/CPASS.FOR

Fix:

1. Fetch the files listed above and place them in the corresponding area ($QPGNOT) on your system.
2. COMLNK $QPGNOT/{B,C}PASS

Documentor:

Eric W Greisen

Date:

2019-07-12

Task:

CLIP, ACLIP

Summary: tasks did not address the arrays properly when trying to report the flagging results when the polarization axis did not start with 1 (I) or -1 (RR). In particular, linear polarization results were reported rather incorrectly.

Files:

/31DEC18/APL/PGM/NOTST/CLIP.FOR

/31DEC18/APL/PGM/NOTST/ACLIP.FOR

Fix:

1. Fetch the files listed above and place them in the corresponding area ($APGNOT) on your system.
2. COMLNK $APGNOT/*CLIP.FOR

Documentor:

Eric W Greisen

Date:

2019-07-26

Task:

UVFLG

Summary: will loop over subarray when flagging data for shadowing. The code, however, used the antenna data from the highest subarray for all subarrays when it did this looping (rather than doing only one selected subarray). Corrected to use the appropriate data for each subarray.

Files:

/31DEC18/APL/PGM/NOTST/UVFLG.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($APGNOT) on your system.
2. COMLNK $APGNOT/UVFLG

Documentor:

Eric W Greisen

Date:

2019-08-22

Task:

BPWAY

Summary: does its main operation on each scan separately. It failed to close its table IO at the end of each scan. It was smart enough to get a new LUN each time until scan 40, at which it encountered an LUN already in use.

Files:

/31DEC18/APL/PGM/NOTST/BPWAY.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($APGNOT) on your system.
2. COMLNK $APGNOT/BPWAY

Documentor:

Eric W Greisen

Date:

2019-09-30

Task:

TYSMO

Summary: used the flag table I/O routine to read the flag table and hence had different logic regarding the flag table record number than the standard flagging routines. It was able to skip some of the flags as a consequence. The error has been corrected.

Files:

/31DEC18/APL/PGM/NOTST/TYSMO.FOR

Fix:

1. Fetch the file listed above and place it in the corresponding area ($APGNOT) on your system.
2. COMLNK $APGNOT/TYSMO.FOR

Documentor:

Eric W Greisen

Date:

2019-11-18

Task:

Summary:

Files:

/31DEC18/??

Fix:

1. Fetch the file listed above and place it in the corresponding area ($) on your system.
2. COMLNK $??/??

Documentor:

Eric W Greisen

Date:

2019-??-??